Perf: Improve gkr-mimc memory use #1616
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c6b830c.
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes memory usage in the GKR-MiMC implementation by introducing memory pooling for field element allocations and adding a specialized SumExp17 operation. The changes result in a 20% reduction in heap allocation (from 2267.45 MB to 1798.62 MB) for BLS12-377 benchmarks.
- Memory pool implementation in
gateAPIto reduce heap allocations - New
SumExp17method for optimized computation of (a+b+c)^17 operations - Refactoring from global to instance-based API usage patterns
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| std/gkrapi/gkr/types.go | Adds SumExp17 method to GateAPI interface |
| std/gkrapi/compile.go | Wraps API with FrontendAPIWrapper for gate evaluation |
| internal/gkr/gkr.go | Adds FrontendAPIWrapper with SumExp17 implementation |
| std/permutation/gkr-mimc/gkr-mimc.go | Optimizes addPow17 function with BLS12-377 specific caching |
| Multiple internal/gkr/*/gkr.go | Implements memory pooling in gateAPI across all curve implementations |
| Multiple internal/gkr/*/solver_hints.go | Updates to use instance-based gateAPI |
| Test files | Renames hashTreeCircuit to merkleTreeCircuit and improves test configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the amount of heap allocations in the benchmark of a 2^16 BLS12-377 element long hash down to 1798.62 MB on an hpc6a.48xlarge machine. This constitutes a 20% improvement over the linea-monorepo baseline (2267.45 MB.)
Most of the improvement was achieved by introducing a reusable pool / stack for temporary field element variables, and is generic to any use of the GKR API.
A further reduction was due to a hard-coded implementation of the most commonly used MiMC gate in BLS12-377, which is
(state + msg + key)^17.I believe that for small instance sizes (< 2^16) the cost is dominated by the GKR verifier and the PLONK prover itself. From that point on, the slope of the fitted line (<1) suggests an at most linear rate of growth.
Note
Introduce a pooled, pointer-based GateAPI (with SumExp17) and plumb it through GKR/MiMC paths to cut heap allocations; update engine hints, templates, SNARK wrapper, and tests/benchmarks.
gateAPIwith a synchronous memory pool (allocated,nbUsed), pointer receivers,newElement,freeElements, and methodcastrefactor.SumExp17inGateAPI; addFrontendAPIWrapper.SumExp17for in-circuit use; update interface instd/gkrapi/gkr/types.go.apiusage with localgateAPIinstances and pass by pointer in evaluation paths (computeGJ, degree checks, equality tests, hints,Complete).wire.Gate.Evaluateto useFrontendAPIWrapper.gateAPIto holdmod *big.Int; fix modular reductions.frontend.Variableper curve; register gates using new types.SumExp17path for degree-17 S-box; keep pow5/pow7 forms.gateAPIand pointer API.freeElements()calls in loops hot paths.Written by Cursor Bugbot for commit f6613ce. This will update automatically on new commits. Configure here.